Clearing ti.next_method and ti.next_kwargs on task finish.

[ReadytoRocc]

Extending the changes of #18210 to all cases of a task finishing in ti._run_raw_task().

• closes: Deferred TI's next_method is not cleared when Clearing a Successful Task #19120
• related: Deferred TI's next_method and next_kwargs not cleared on retries #18146

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[ReadytoRocc]

• Updated tests to be parameterized per @jedcunningham's suggestion.
• Added session.merge(self) to failure case in _run_raw_task (if State.finished) where we now need to commit. This follows the other cases.

[jedcunningham]

Suggested change

	def failure():
	raise AirflowException
	def skip():
	raise AirflowSkipException
	def success():
	return None
	def reschedule():
	reschedule_date = timezone.utcnow()
	raise AirflowRescheduleException(reschedule_date)
	_retries = 0
	_retry_delay = datetime.timedelta(seconds=0)
	if state == State.FAILED:
	_python_callable = failure
	elif state == State.SKIPPED:
	_python_callable = skip
	elif state == State.SUCCESS:
	_python_callable = success
	elif state == State.UP_FOR_RESCHEDULE:
	_python_callable = reschedule
	elif state in [State.FAILED, State.UP_FOR_RETRY]:
	_python_callable = failure
	_retries = 1
	_retry_delay = datetime.timedelta(seconds=2)
	with dag_maker("test_deferred_method_clear"):
	task = PythonOperator(
	task_id="test_deferred_method_clear_task",
	python_callable=_python_callable,
	def run(state):
	if state == State.FAILED:
	raise AirflowException
	if state == State.SKIPPED:
	raise AirflowSkipException
	if state == State.UP_FOR_RESCHEDULE:
	raise AirflowRescheduleException(timezone.utcnow())
	return None # SUCCESS
	_retries = 0
	_retry_delay = datetime.timedelta(seconds=0)
	if state in [State.FAILED, State.UP_FOR_RETRY]:
	_retries = 1
	_retry_delay = datetime.timedelta(seconds=2)
	with dag_maker("test_deferred_method_clear"):
	task = PythonOperator(
	task_id="test_deferred_method_clear_task",
	python_callable=run,
	op_args=[state],

Do the retries and retry_delay differences actually matter?

[jedcunningham]

@ReadytoRocc, I'm going to merge this for 2.2.1, but can you follow up with refactoring the test when you get the chance? Thanks.

[ReadytoRocc]

@jedcunningham thanks for the the suggestions. Will do.

[ReadytoRocc]

Do the retries and retry_delay differences actually matter?
@jedcunningham I believe it would only matter for the following cases:

1. State.FAILED needs retries set to 0 so that task goes into a state of failed.
2. State.UP_FOR_RETRY needs retries set to 1 so that task goes into a state of retry.

I believe we can set _retry_delay once, default _retries = 0, and then only set _retries = 1, if State.UP_FOR_RETRY.

[ReadytoRocc]

@jedcunningham - PR for refactored tests: #19194

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[jedcunningham]

@ReadytoRocc, congrats on your first commit 🎉🚀