Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary connection form customizations in Azure #19595

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Remove unnecessary connection form customizations in Azure #19595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions airflow/providers/microsoft/azure/hooks/container_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,13 @@ def get_connection_form_widgets() -> Dict[str, Any]:
@staticmethod
def get_ui_field_behaviour() -> Dict:
"""Returns custom field behaviour"""
import json

return {
"hidden_fields": ['schema', 'port', 'host', "extra"],
"relabeling": {
'login': 'Azure Client ID',
'password': 'Azure Secret',
},
"placeholders": {
'extra': json.dumps(
{
"key_path": "path to json file for auth",
"key_json": "specifies json dict for auth",
},
indent=1,
),
'login': 'client_id (token credentials auth)',
'password': 'secret (token credentials auth)',
'extra__azure_container_volume__connection_string': 'connection string auth',
Expand Down
2 changes: 0 additions & 2 deletions airflow/providers/microsoft/azure/hooks/fileshare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,10 @@ def get_ui_field_behaviour() -> Dict:
"relabeling": {
'login': 'Blob Storage Login (optional)',
'password': 'Blob Storage Key (optional)',
'host': 'Account Name (Active Directory Auth)',
},
"placeholders": {
'login': 'account name',
'password': 'secret',
'host': 'account url',
'extra__azure_fileshare__sas_token': 'account url or token (optional)',
'extra__azure_fileshare__connection_string': 'account url or token (optional)',
'extra__azure_fileshare__protocol': 'account url or token (optional)',
Expand Down