Clarify Helm behaviour when it comes to loading default connections #19708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Users find it surprising that our Helm Chart does not load the default connections. This is deliberate choice because Helm Chart should not manage the database content and the default connections are just "quick start" type of data, but this should be explicitly stated in the documentaiton of Helm's configuration. This PR fixes it. See also discussion in apache#19688
potiuk
force-pushed
the
clarify-production-database-helm
branch
from
814730b
to
d923419
Compare
kaxil
approved these changes
Nov 24, 2021
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users find it surprising that our Helm Chart does not load the
default connections. This is deliberate choice because Helm Chart
should not manage the database content and the default connections
are just "quick start" type of data, but this should be explicitly
stated in the documentaiton of Helm's configuration.
This PR fixes it. See also discussion in #19688
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.