Chart: PgBouncer service enhancements #19749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
ashb,
dimberman,
jedcunningham and
kaxil
as code owners
kaxil
reviewed
Nov 24, 2021
kaxil
reviewed
Nov 24, 2021
|
@pgvishnuram Can you rebase on main branch & resolve conflicts please |
|
okay sure . let me re-verify them |
* Added support for extraVolumes and Volumemounts * Added seperate sslmode for metrics exporter * Fixed condition for pgbouncer volume mounts * Added test cases
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
pgvishnuram
requested review from
bbovenzi,
dstandish,
ephraimbuddy,
jhtimmins,
mik-laj,
potiuk,
ryanahamilton,
turbaszek,
uranusjr,
vikramkoka and
XD-DENG
as code owners
kaxil
force-pushed
the
add_extravolume_support_for_pgbouncer
branch
from
3f171ba
to
d35199c
Compare
kaxil
removed request for
ryanahamilton,
uranusjr,
jhtimmins,
turbaszek and
XD-DENG
kaxil
reviewed
Dec 9, 2021
kaxil
reviewed
Dec 9, 2021
kaxil
reviewed
Dec 9, 2021
kaxil
changed the title
kaxil
approved these changes
Dec 9, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Dec 9, 2021
jedcunningham
requested changes
Dec 9, 2021
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
jedcunningham
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
pgbouncer does not support additional volume and volume mounts this lacks feature to add client side tls certificates.
Additionally pgbouncer MetricExporter sslmode is hardcoded at all times, this breaks if user tries to set sslmode=require
How does this PR fix the problem above:
This PR below functionality to solve above issues
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.