-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate passing execution_date to XCom methods #19825
Conversation
As part of AIP-39 (released in 2.2) we added `run_id` parameters to XCom methods, and this changes it so that passing by run_id is the recommended approach. A future PR will change the columns on the xcom table to store run_id (instead/as well as exeuction_date) but that will be for 2.3, where as this change can be backported to 2.2.x
5509eeb
to
2c8862f
Compare
486b76e
to
2d2b72d
Compare
Both the "modern" run_id and deprecated execution_date approaches.
2bb7bcd
to
fdef902
Compare
I’ve made all tests work and migrated most existing XCom usages to use I also want to extract typing changes I made here into a separate PR, and merge that first before I mark this PR as ready for review. |
Merging in the Mypy and Sphinx fixes, let’s see this works. |
Oh everything is 🟢 now! |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note in UPDATING.md
too plz around the deprecation
|
As part of AIP-39 (released in 2.2) we added
run_id
parameters to XCommethods, and this changes it so that passing by run_id is the
recommended approach.
A future PR will change the columns on the xcom table to store run_id
(instead/as well as exeuction_date) but that will be for 2.3, where as
this change can be backported to 2.2.x
Discussion thread: https://lists.apache.org/thread/gofj3g6m6vvksy6n0cmgq1qxd309bbbl