Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify kernel name in PapermillOperator #20035

Conversation

minhthong582000
Copy link
Contributor

This PR adds a kernel_name field to PapermillOperator so we can specify name of kernel to execute the notebook against.
If kernel_name is specifed, papermill ignores kernel name in the notebook document metadata.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume python3 is currently an implicit default @minhthong582000 ?

@potiuk potiuk closed this Dec 4, 2021
@potiuk potiuk reopened this Dec 4, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 4, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@minhthong582000
Copy link
Contributor Author

I assume python3 is currently an implicit default @minhthong582000 ?

If kernel_name is None, papermill will look at the notebook document metadata, like:

 "metadata": {
  "celltoolbar": "Tags",
  "kernelspec": {
   "display_name": "Python 3",
   "language": "python",
   "name": "python3" 
  },

Here i'm just using the kernel that i found from this example.

@potiuk
Copy link
Member

potiuk commented Dec 4, 2021

I assume python3 is currently an implicit default @minhthong582000 ?

If kernel_name is None, papermill will look at the notebook document metadata, like:

 "metadata": {
  "celltoolbar": "Tags",
  "kernelspec": {
   "display_name": "Python 3",
   "language": "python",
   "name": "python3" 
  },

Here i'm just using the kernel that i found from this example.

Ah perfect!

@potiuk potiuk merged commit d3f4456 into apache:main Dec 4, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants