Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes InputRequired validation with azure extra #20084

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 6, 2021

The change #19923 introduced (accidentally) a required validation
for an azure extra, which caused an error in the connection
UI when the connection could not be added because the field was
missing.

This failed the test_crate_connection fail.

This change removes back the validation.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The change apache#19923 introduced (accidentally) a required validation
for an azure extra, which caused an error in the connection
UI when the connection could not be added because the field was
missing.

This failed the test_crate_connection fail.

This change removes back the validation.
@potiuk
Copy link
Member Author

potiuk commented Dec 6, 2021

cc: @josh-fell - I wonder where the InputRequired came from :D . It does not seem to be needed by MyPy.

@potiuk potiuk merged commit 42f133c into apache:main Dec 6, 2021
@potiuk potiuk deleted the fix-failing-add-connection-tests branch December 6, 2021 19:55
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 6, 2021
@josh-fell
Copy link
Contributor

cc: @josh-fell - I wonder where the InputRequired came from :D . It does not seem to be needed by MyPy.

I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because Subcription ID is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.

@potiuk
Copy link
Member Author

potiuk commented Dec 6, 2021

I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because Subcription ID is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.

Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden and will block adding ANOTHER connection (this is what happened in the test - our test nicely caught it)

@josh-fell
Copy link
Contributor

I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because Subcription ID is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.

Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden and will block adding ANOTHER connection (this is what happened in the test - our test nicely caught it)

Will do, thanks for the heads up! Would be a shame if custom forms couldn't set required-field validations on these "extra" fields. Not a big deal though.

@potiuk potiuk restored the fix-failing-add-connection-tests branch April 26, 2022 20:48
@potiuk potiuk deleted the fix-failing-add-connection-tests branch July 29, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants