Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'cx_Oracle' driver does support autocommit #20085

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

malthe
Copy link
Contributor

@malthe malthe commented Dec 6, 2021

It's been supported since version 4.3.2 – released in August, 2007.

The insert_rows and bulk_insert_rows methods have been updated to explicitly disable autocommit using the attribute interface (although that is presumably the default) – since in insert_rows this was previously already done (via the cursor).

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/oracle/python-cx_Oracle/blob/5728cf534e24319640b52ea0e93c5042fe210f22/doc/src/release_notes.rst#version-432-august-2007

Autommit support was added in 4.3.2, while the provider is currently requiring cx_Oracle>=5.1.2, so this is good to go.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants