Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20139 - organize aws step_function #20158

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Conversation

bhavaniravi
Copy link
Contributor

Part of #20139

Move step_function_* operators and sensors to step_function.py

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also missing edits to the test files of the operators / sensors.

Sensor:
https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/sensors/test_step_function_execution.py
should also be renamed and fix imports.

Operators:
https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/operators/test_step_function_get_execution_output.py

https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/operators/test_step_function_start_execution.py

also since the classes are small we can have both of them in a single test_step_function.py and we can remove the two individual test files.

tests/deprecated_classes.py Outdated Show resolved Hide resolved
tests/deprecated_classes.py Outdated Show resolved Hide resolved
tests/deprecated_classes.py Outdated Show resolved Hide resolved
@kaxil kaxil removed their request for review December 10, 2021 13:53
@eladkal
Copy link
Contributor

eladkal commented Dec 12, 2021

@bhavaniravi could you please address also the comments on test files?

@bhavaniravi
Copy link
Contributor Author

@bhavaniravi could you please address also the comments on test files?

Yes on it.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 13, 2021
@eladkal eladkal removed the full tests needed We need to run full set of tests for this PR to merge label Dec 13, 2021
@eladkal eladkal merged commit 1d2f2d3 into apache:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants