Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix network policy issue for webserver and flowerui #20199

Merged

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Dec 10, 2021

Issue Description:

Once platform deployed in openshift, when we install any of kubernetes/celery/local executors - we wont be able to access the UI after the deployment is sucessfull and ends up with error message as "request timed out"

Behaviour Observed:
After debugging the issue , seems to be openshift network SDN does not recognise port-name in network policy and requires port-number to be defined to work properly

Openshift Logs:

networkpolicy.go:556] Ignoring rule in
 NetworkPolicy astronomer-spherical-speed-xxxx/spherical-speed-xxxx-webserver-policy with unsupported named port "airflow-ui" - openshift-sdn logs  


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

chart/tests/test_flower.py Outdated Show resolved Hide resolved
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
chart/tests/test_flower.py Show resolved Hide resolved
chart/values.schema.json Outdated Show resolved Hide resolved
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oops, wrong one)

chart/UPDATING.rst Outdated Show resolved Hide resolved
chart/UPDATING.rst Outdated Show resolved Hide resolved
pgvishnuram and others added 5 commits December 15, 2021 00:01
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 15, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor changes to the UPDATING doc @pgvishnuram.

chart/UPDATING.rst Outdated Show resolved Hide resolved
chart/UPDATING.rst Outdated Show resolved Hide resolved
pgvishnuram and others added 2 commits December 16, 2021 00:11
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@jedcunningham
Copy link
Member

@pgvishnuram, looks like there is a conflict in UPDATING.rst as well. Can you tackle that too?

@eladkal eladkal added this to the Airflow Helm Chart 1.4.0 milestone Dec 19, 2021
@jedcunningham jedcunningham reopened this Dec 29, 2021
@jedcunningham jedcunningham merged commit 939724b into apache:main Dec 29, 2021
@himabindu07
Copy link

validated this issue : airflow chart version: 1.0.0-rc3
Observed behavior: when I create deployment without deleting NetworkPolicies deployment is in a healthy state, When I do astro deploy able to see the dags on Airflow UI.
Screen Shot 2022-01-06 at 11 28 50 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants