Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-ignore DeprecationWarning #20322

Merged
merged 20 commits into from
Dec 21, 2021
Merged

Un-ignore DeprecationWarning #20322

merged 20 commits into from
Dec 21, 2021

Commits on Dec 17, 2021

  1. Un-ignore DeprecationWarning

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    907df2e View commit details
    Browse the repository at this point in the history

  2. Fix deprecation warnings in external task sensors 

    Unfortunately, external task sensors reference "execution date" quite
extensively, and even include it as a part of its public API (both that
exact variable, and things like execution_offset and excution_date_fn).
It is definitely possible to migrate them to something else, but it is
some substential work, and I actually suspect these aren't used widely,
if by anyone at all, since we did not receive a single report pointing
out those are currently emitting DeprecationWarning messages from core
Airflow code. So I'm going to leave the public interface alone for now,
and only change the internals to not emit warnings.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    b3fe112 View commit details
    Browse the repository at this point in the history

  3. Fix deprecation warnings from DayOfWeekSensor 

    Similar to ExternalTaskSensor, the execution date terminology is
unfortunately a part of its public API. This one is easier to deprecate,
but again, it's entirely unclear how many people are actually using
this, especially now we have async triggers. So I'm leaving the
interface alone.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    ab8d04e View commit details
    Browse the repository at this point in the history

  4. Fix deprecation warning in BranchDateTimeOperator 

    Again, execution date is unfortunately a part of the operator's public
interface. But again, better to leave it again. 🤷
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    ac74e42 View commit details
    Browse the repository at this point in the history

  5. Don't use execution_date in EmailOperator test

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    dfbad0a View commit details
    Browse the repository at this point in the history

  6. Use logical date directly in ShortCircuitOperator

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    03e6e8b View commit details
    Browse the repository at this point in the history

  7. Allow deprecations in some Python callable tests 

    Where we actually want to make sure those arguments work properly.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    e519cf1 View commit details
    Browse the repository at this point in the history

  8. No execution_date in BranchDayOfWeekOperator test

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    e283cfe View commit details
    Browse the repository at this point in the history

  9. No execution_date in HttpSensor test

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    bbc6a53 View commit details
    Browse the repository at this point in the history

  10. Do not eagerly resolve context in HTTP operators 

    To avoid deprecated context variables emitting warnings, we must call
determine_kwargs directly on the context mapping first, instead of using
the make_kwargs_callable wrapper, which uses **kwargs and eagerly access
all the members.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    baf86b3 View commit details
    Browse the repository at this point in the history

  11. Use our own Jinja renderer for log filename 

    Similar to other Jinja rendering situations, we can't just pass
**context into Template.render().
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    71544b1 View commit details
    Browse the repository at this point in the history

  12. Remove execution_date from BranchDayOfWeekOperator 

    Similar to DayOfWeekSensor and BranchDateTimeOperator, this also has
execution date in its public interface. But let's not deal with it now.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    6af3823 View commit details
    Browse the repository at this point in the history

  13. Use custom Jinja renderer for custom log formatter 

    Same as the regular handler.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    87dee96 View commit details
    Browse the repository at this point in the history

  14. Replace eager Jinja rendering on email-sending 

    More of the same thing.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    357c46e View commit details
    Browse the repository at this point in the history

  15. Remove **kwargs and mark deprecated calls in tests

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    dba4ada View commit details
    Browse the repository at this point in the history

  16. Allow deprecated in print_the_context tests

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    691bef6 View commit details
    Browse the repository at this point in the history

  17. Refactor to use lazy proxy on callable with **kw 

    Due to how Python works, we can't make the keyword argument dict lazy,
and calling fn(**context) would emit deprecation warnings too eagerly.
The previous warning strategy with lazy-object-proxy is brought back for
this particular use case, and only deprecated entries are converted to
lazy proxies if the context is being unpacked, to keep possible
incompatibilities minimal.
    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    0885f0e View commit details
    Browse the repository at this point in the history

  18. Remove context warning ignores no longer needed

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    e5e56a2 View commit details
    Browse the repository at this point in the history

  19. Remove Context-related functions from docs

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    b3b780f View commit details
    Browse the repository at this point in the history

  20. Remove option to ignore deprecation warnings on CI

    @uranusjr
    uranusjr committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    c142089 View commit details
    Browse the repository at this point in the history