Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scheduler crash when executing task instances of missing DAG #20349

Merged
merged 9 commits into from
Jan 13, 2022
Merged

Fix Scheduler crash when executing task instances of missing DAG #20349

merged 9 commits into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. Fix Scheduler crash when executing task instances of missing DAG 

    When executing task instances, we do not check if the dag is missing in
the dagbag. This PR fixes it by ignoring task instances if we can't find
the dag in serialized dag table
    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    63e81ac View commit details
    Browse the repository at this point in the history

  2. fixup! Fix Scheduler crash when executing task instances of missing DAG

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    996ae4a View commit details
    Browse the repository at this point in the history

  3. Split 'task instance' into two words

    @uranusjr @ephraimbuddy
    uranusjr authored and ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    b0c1ae5 View commit details
    Browse the repository at this point in the history

  4. apply suggestions from code review

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    20e3408 View commit details
    Browse the repository at this point in the history

  5. fixup! apply suggestions from code review

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    b03f8cd View commit details
    Browse the repository at this point in the history

  6. fixup! fixup! apply suggestions from code review

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7d9c002 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
    @ephraimbuddy @kaxil
    ephraimbuddy and kaxil committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    cfeb9ee View commit details
    Browse the repository at this point in the history

  8. set all scheduled tasks of the missing dag to NONE state

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    4ca34f6 View commit details
    Browse the repository at this point in the history

  9. fail the tasks instances rather than set to none

    @ephraimbuddy
    ephraimbuddy committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3c5079f View commit details
    Browse the repository at this point in the history