Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to set all tasks to skipped #20455

Merged
merged 6 commits into from Jan 4, 2022
Merged

Add a button to set all tasks to skipped #20455

merged 6 commits into from Jan 4, 2022

Conversation

adamspriggs
Copy link
Contributor

This change is a request from a user of our platform - which uses Airflow.

When there is an issue with the scheduler, the tasks/dags are not running. Instead of setting all the missed task runs to failure or success, etc.. they want a way to set them to skipped. Signifying that they were not run so failed nor success does not identify the state of the task correctly.

This small change adds the button to the tasks page in the dag, set_action_skipped.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Dec 21, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 21, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

airflow/www/views.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@bbovenzi
Copy link
Contributor

bbovenzi commented Jan 4, 2022

Looks good! Would you mind also adding skipped as an option when a user clicks on the Edit record button?

Screen Shot 2022-01-04 at 10 12 10 AM

Screen Shot 2022-01-04 at 10 10 52 AM

@adamspriggs
Copy link
Contributor Author

Looks good! Would you mind also adding skipped as an option when a user clicks on the Edit record button?

Screen Shot 2022-01-04 at 10 12 10 AM Screen Shot 2022-01-04 at 10 10 52 AM

Does the edit record button work for you...? Went into the network dev tools to see where it is showing the records and it doesn't even set the state to failed/up_for_retry, etc..

@bbovenzi
Copy link
Contributor

bbovenzi commented Jan 4, 2022

Looks good! Would you mind also adding skipped as an option when a user clicks on the Edit record button?
Screen Shot 2022-01-04 at 10 12 10 AM
Screen Shot 2022-01-04 at 10 10 52 AM

Does the edit record button work for you...? Went into the network dev tools to see where it is showing the records and it doesn't even set the state to failed/up_for_retry, etc..

You're right. That doesn't work. I will open up a separate issue for that. In that case, this PR looks good to me.

Edit: New issue here: #20655

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 4, 2022
@bbovenzi bbovenzi merged commit 298435a into apache:main Jan 4, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 4, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants