Generate constraints in PRs when upgrading dependencies #20624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constraints generation was only happening in push/scheduled runs, but sometimes it is useful to check what constraints would be generated even in the PRs that change setup.py/setup.cfg The change causes constraint generation also in the PRs and only pushing the updated constraints is not executed in PRs.
mik-laj
approved these changes
Jan 2, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This was referenced Jan 3, 2022
Merged
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 3, 2022
The apache#20624 broke PRs that are changing setup.py. This PR fixes it.
potiuk
added a commit
that referenced
this pull request
Jan 3, 2022
The #20624 broke PRs that are changing setup.py. This PR fixes it.
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
The constraints generation was only happening in push/scheduled runs, but sometimes it is useful to check what constraints would be generated even in the PRs that change setup.py/setup.cfg The change causes constraint generation also in the PRs and only pushing the updated constraints is not executed in PRs. (cherry picked from commit f668fa7)
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
The constraints generation was only happening in push/scheduled runs, but sometimes it is useful to check what constraints would be generated even in the PRs that change setup.py/setup.cfg The change causes constraint generation also in the PRs and only pushing the updated constraints is not executed in PRs. (cherry picked from commit f668fa7)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraints generation was only happening in push/scheduled
runs, but sometimes it is useful to check what constraints would
be generated even in the PRs that change setup.py/setup.cfg
The change causes constraint generation also in the PRs and only
pushing the updated constraints is not executed in PRs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.