Fix entire DAG stops when one task has end_date #20920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert all the whitespace changes. They make static checks fail, and it’s extremely difficult to review what you actually want to change due to all the noise. |
potiuk
reviewed
Feb 15, 2022
potiuk
approved these changes
Mar 7, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
@chenglongyan please rebase |
|
I'm sorry, I've been too busy lately, I'll follow up in time |
uranusjr
reviewed
Mar 25, 2022
Comment on lines
799
to
804
| def task_filter(task: "Operator") -> bool: | ||
| return task.task_id not in task_ids and ( | ||
| self.is_backfill or task.start_date <= self.execution_date | ||
| self.is_backfill | ||
| or task.start_date <= self.execution_date | ||
| and (task.end_date is None or self.execution_date <= task.end_date) | ||
| ) |
There was a problem hiding this comment.
Let’s refactor this to early returns to improve readability, something like
def task_filter(task: "Operator") -> bool:
if task.task_id in task_ids:
return False
if self.is_backfill:
return ...
...
return ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #19917 , #20471