Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list item to be rendered instead of showing as JSON #21227

Closed
wants to merge 1 commit into from

Conversation

avkirilishin
Copy link
Contributor

closes: #13988
related: #17321
related: #11177

#17321 broke a list item rendering that was introduced in #14024.
This PR fixes it again and adds some tests to avoid problems in the future.

Impact on operators:

Operator Before PR After
VerticaOperator image image
PythonOperator image image
TaskFlow image image
SimpleHttpOperator image image
BigQueryInsertJobOperator image image

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:providers area:webserver Webserver related Issues labels Jan 30, 2022
@uranusjr
Copy link
Member

What changed in BigQueryInsertJobOperator? The two images look the same to me.

@avkirilishin
Copy link
Contributor Author

What changed in BigQueryInsertJobOperator? The two images look the same to me.

Yes, they are the same. Nothing changed in BigQueryInsertJobOperator.

@uranusjr
Copy link
Member

I guess my question is, why are the screenshots attached if nothing changes there?

@avkirilishin
Copy link
Contributor Author

To emphasize that the functionality from #17321 is not broken

@uranusjr
Copy link
Member

I see, thanks for the clarification.

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 18, 2022
@peloyeje
Copy link
Contributor

Hi, first of all thanks for the fix! What is the expected timeframe to see this one merged?

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 22, 2022
@potiuk
Copy link
Member

potiuk commented Mar 27, 2022

@peloyeje I guess it will be there as soon as the author (@avkirilishin ) rebaases it and fixes the static checks that were failing. Or if the author does not do it, maybe someone (you @peloyeje ) take it over and lead it to completion.

@peloyeje
Copy link
Contributor

peloyeje commented Apr 4, 2022

@peloyeje I guess it will be there as soon as the author (@avkirilishin ) rebaases it and fixes the static checks that were failing. Or if the author does not do it, maybe someone (you @peloyeje ) take it over and lead it to completion.

All right no problem will do :)

@peloyeje
Copy link
Contributor

peloyeje commented Apr 8, 2022

Hi @potiuk here you go! #22854
Let me know if everything is ok, it's my first time here

@potiuk
Copy link
Member

potiuk commented Apr 13, 2022

Static checks failing - I recommend to rebasem and run pre-commit locally to test it.

@peloyeje
Copy link
Contributor

peloyeje commented Apr 17, 2022

Static checks failing - I recommend to rebasem and run pre-commit locally to test it.

Hi @potiuk!
AFAIK I'm not allowed to push into avkirilishin's branch (can I?) so I opened this PR instead: static tests are supposed to be ok on this (breeze static-checks --last-commit pass) + I rebased on latest upstream

@eladkal
Copy link
Contributor

eladkal commented May 25, 2022

Closed in favor of #22854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:providers area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List and Dict template fields are rendered as JSON.
5 participants