Refactor operator links to not create ad hoc TaskInstances #21285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
uranusjr
approved these changes
Feb 3, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
josh-fell
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
|
Merging. The only failure is the MsSQL that I work on in #21272 |
54 tasks
This was referenced Feb 8, 2022
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Feb 22, 2022
jedcunningham
added
the
changelog:skip
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Dec 9, 2023
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Dec 9, 2023
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Dec 9, 2023
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Dec 9, 2023
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
potiuk
pushed a commit
that referenced
this pull request
Dec 10, 2023
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with #21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that there is now a foreign key constraint between
TaskInstanceandDagRun, ideally ad hocTaskInstanceobjects shouldn't be created within operator links. See this comment.Almost all of the existing operator links can be refactored to using
XCom.get_one()to pull the necessaryXComto generate the URL needed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.