Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to upload file to Google Shared Drive #21319

Merged
merged 5 commits into from
Feb 6, 2022

Conversation

lihan
Copy link
Contributor

@lihan lihan commented Feb 4, 2022

Adding support to upload file to Shared Drive if file parent is in a Google Shared Drive

@lihan lihan requested a review from turbaszek as a code owner February 4, 2022 09:33
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 4, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 5, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Feb 5, 2022

Some relevant tests are failing :(

@lihan
Copy link
Contributor Author

lihan commented Feb 6, 2022

@turbaszek @potiuk I updated the tests, can you trigger the Github test again?

@potiuk potiuk closed this Feb 6, 2022
@potiuk potiuk reopened this Feb 6, 2022
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix static checks

tests/providers/google/suite/hooks/test_drive.py Outdated Show resolved Hide resolved
tests/providers/google/suite/hooks/test_drive.py Outdated Show resolved Hide resolved
@potiuk
Copy link
Member

potiuk commented Feb 6, 2022

Just intermittent error . merging.

@potiuk potiuk merged commit 6b88d43 into apache:main Feb 6, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 6, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants