New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test connection functionality to use custom form fields #21330
Conversation
55f7cc1
to
fe9bede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josh-fell for brave attempt to improve that piece of javascript ;)
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
fe9bede
to
e31b047
Compare
Just the docker-compose timout problem |
I'm going to kick this to 2.3.0 because of the number of other changes that have happened to connection testing since 2.2.x forked off. We can always reevaluate for 2.2.5 (if there is one) if we think this would work on its own. |
Closes: #21188
Currently the test connection functionality in the UI doesn't account for custom form fields. This PR intends to include custom form fields as part of the testing mechanism.
When testing, if the
Extra
field is not a valid JSON, an error message is displayed to the user to help provide some direction. (The simple JSON parsing check doesn't definitively assess whether the value is valid JSON but the edge cases liketrue
,{false}
,1
, etc. would be effectively useless for the connection anyway. Thinking providing some feedback to users was valuable here especially for syntax errors of manually entering a JSON object.)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.