Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test connection functionality to use custom form fields #21330

Merged
merged 1 commit into from Feb 15, 2022

Conversation

josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Feb 4, 2022

Closes: #21188

Currently the test connection functionality in the UI doesn't account for custom form fields. This PR intends to include custom form fields as part of the testing mechanism.

Before After
image image

When testing, if the Extra field is not a valid JSON, an error message is displayed to the user to help provide some direction. (The simple JSON parsing check doesn't definitively assess whether the value is valid JSON but the edge cases like true, {false}, 1, etc. would be effectively useless for the connection anyway. Thinking providing some feedback to users was valuable here especially for syntax errors of manually entering a JSON object.)

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 4, 2022
@josh-fell josh-fell marked this pull request as ready for review February 4, 2022 16:57
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josh-fell for brave attempt to improve that piece of javascript ;)

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi closed this Feb 11, 2022
@bbovenzi bbovenzi reopened this Feb 11, 2022
@potiuk
Copy link
Member

potiuk commented Feb 15, 2022

Just the docker-compose timout problem

@potiuk potiuk merged commit a9b8ac5 into apache:main Feb 15, 2022
@kaxil kaxil modified the milestones: Airflow 2.2.5, Airflow 2.2.4 Feb 15, 2022
@josh-fell josh-fell deleted the test-conn-custom-form-fields branch February 15, 2022 22:34
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Feb 15, 2022
@jedcunningham
Copy link
Member

I'm going to kick this to 2.3.0 because of the number of other changes that have happened to connection testing since 2.2.x forked off. We can always reevaluate for 2.2.5 (if there is one) if we think this would work on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Test Connection" functionality in the UI doesn't consider custom form fields
5 participants