Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize approach to dependencies #21356

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 6, 2022

Approach to dependencies we had (especially with regards to
upper bounds) was pretty random so far. This PR attempts to
describe the rules discussed in the devlist discussion - including
review and update of all dependencies to match the policies.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk marked this pull request as draft February 6, 2022 12:22
setup.py Show resolved Hide resolved
Approach to dependencies we had (especially with regards to
upper bounds) was pretty random so far. This PR attempts to
describe the rules discussed in the devlist discussion - including
review and update of all dependencies to match the policies.
@potiuk potiuk marked this pull request as ready for review February 12, 2022 17:36
@potiuk potiuk force-pushed the introduce-policy-for-dependency-limits branch from bd34388 to 519e5ef Compare February 12, 2022 17:36
@potiuk
Copy link
Member Author

potiuk commented Feb 12, 2022

I think that one is pretty read if we will be ok with introducing the policies as I proposed .

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see how this shakes out.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 14, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member Author

potiuk commented Feb 14, 2022

Well. We do not really risk much. We can always limit troublesome deps if we find them troublesome.

We always have "escape hatch" -> use constraints.

Plus more and more people use images actually wich makes them naturally constrained to what we produce.

And we did not really had many of those in the first place actually.

@potiuk potiuk merged commit 7864693 into apache:main Feb 14, 2022
@potiuk potiuk deleted the introduce-policy-for-dependency-limits branch February 14, 2022 22:34
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants