Normalize *_conn_id parameters in BigQuery sensors #21430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes deprecation warning in `BigQueryHook` because of `bigquery_conn_id` parameter usage from sensors code. Note: similar change for BigQuery operators was already performed in commit 042a9ba
boring-cyborg
bot
added
area:providers
provider:google
potiuk
approved these changes
Feb 15, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
added 2 commits
February 15, 2022 14:34
turbaszek
reviewed
Feb 15, 2022
| @@ -64,25 +71,31 @@ def __init__( | |||
| project_id: str, | |||
| dataset_id: str, | |||
| table_id: str, | |||
| bigquery_conn_id: str = 'google_cloud_default', | |||
| gcp_conn_id: str = 'google_cloud_default', | |||
There was a problem hiding this comment.
Just an idea for further improvement - maybe it would be good to introduce constant for this value and use it in all cases?
turbaszek
approved these changes
Feb 15, 2022
84 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gcp_conn_idparameter to BigQuery sensors and deprecatebigquery_conn_idparameter.Pass
gcp_conn_idtoBigQueryHookusinggcp_conn_idto avoid deprecation warning in hook code.Please note that a similar change for BigQuery operators was already performed in commit 042a9ba