Set larger limit get_partitions_by_filter in HiveMetastoreHook #21504
Conversation
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
pingzh
force-pushed
the
pingzh-get_partitions_by_filter
branch
from
57e8f0b
to
78a9df7
Compare
| @@ -556,7 +556,9 @@ def check_for_partition(self, schema: str, table: str, partition: str) -> bool: | |||
| True | |||
| """ | |||
| with self.metastore as client: | |||
| partitions = client.get_partitions_by_filter(schema, table, partition, 1) | |||
| partitions = client.get_partitions_by_filter( | |||
| schema, table, partition, HiveMetastoreHook.MAX_PART_COUNT | |||
There was a problem hiding this comment.
Is this a breaking change?
is 1 is not desirable in all cases? (if there are valid use cases for 1 then maybe we should make the 4th parameter (limit) configurable thus allowing each user to set whatever value he wishes?
There was a problem hiding this comment.
good call. it isn't a breaking change since it is invoked inside check_for_partition, which returns bool.
pingzh
force-pushed
the
pingzh-get_partitions_by_filter
branch
from
78a9df7
to
46e21ba
Compare
pingzh
force-pushed
the
pingzh-get_partitions_by_filter
branch
from
46e21ba
to
20dc017
Compare
With the large size of the hive metastore, setting limit to 1 will create a scan query that is too heavy to handle. Setting the limit to HiveMetastoreHook.MAX_PART_COUNT will generate a query using index and scan much less rows( not guaranteed, depending on the table, some table may still got a scan query but we are limited by thrift lib as the limit is a short int).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.