Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ClientInfo to module level #21554

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Extract ClientInfo to module level #21554

merged 1 commit into from
Feb 15, 2022

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Feb 13, 2022 •
edited

closes: #13231

Hello guys,

Here is a first draft for refactoring the code using the ClientInfo.

  • extract ClientInfo into a shared object at the google provider lvl (into common.consts)
  • mark GoogleBaseHook.client_info as deprecated
  • Modify all code using .client_info or ClientInfo to use this shared CLIENT_INFO constant

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:logging area:providers provider:google Google (including GCP) related issues labels Feb 13, 2022
@eladkal eladkal requested a review from mik-laj February 15, 2022 06:39
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 15, 2022
@potiuk potiuk merged commit 1b568d7 into apache:main Feb 15, 2022
@pierrejeambrun pierrejeambrun deleted the 13231-factorize-client-info-in-google-provider branch February 16, 2022 06:54
@potiuk potiuk mentioned this pull request Mar 7, 2022
Closed
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@turbaszek turbaszek Awaiting requested review from turbaszek

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees
No one assigned
Labels
area:logging area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One ClientInfo instance in Google provider
2 participants
@pierrejeambrun @potiuk