Simplify trigger cancel button #21591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
bbovenzi
approved these changes
Feb 15, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
jedcunningham
force-pushed
the
fix-cancel-button
branch
from
92f648c
to
774d949
Compare
kaxil
approved these changes
Feb 15, 2022
jedcunningham
added
the
changelog:skip
This was referenced Feb 15, 2022
jedcunningham
added a commit
that referenced
this pull request
Feb 15, 2022
Co-authored-by: Jed Cunningham <jedcunningham@apache.org> (cherry picked from commit 6529767)
jedcunningham
added a commit
that referenced
this pull request
Feb 17, 2022
Co-authored-by: Jed Cunningham <jedcunningham@apache.org> (cherry picked from commit 6529767)
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Feb 23, 2022
Co-authored-by: Jed Cunningham <jedcunningham@apache.org> (cherry picked from commit 6529767)
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Feb 23, 2022
Co-authored-by: Jed Cunningham <jedcunningham@apache.org> (cherry picked from commit 6529767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an simpler-yet alternative to #21406 (and #21310).
It still moves to using an anchor over a button, however doesn't double encode as jinja already does it for us.