-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced hql references to sql in TrinoHook and PrestoHook #21597 #21630
Conversation
There are 0 files changed.. probably unsuccessful rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can you please fix the static checks?
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@eladkal, last commit was missing logic to give warning when 'hql' parameter is used, fixed it and static check. |
…documentation.
"""Get a set of records from Presto | ||
:param sql: SQL statement to be executed. | ||
:param parameters: The parameters to render the SQL query with. | ||
""" | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Get a set of records from Presto | |
:param sql: SQL statement to be executed. | |
:param parameters: The parameters to render the SQL query with. | |
""" | |
... | |
"""Get a set of records from Presto. | |
:param sql: SQL statement to be executed. | |
:param parameters: The parameters to render the SQL query with. | |
""" |
One blank line after the first line in the docstring. (See PEP 257)
The ...
part is only needed so the function is not empty, but we already have a docstring here and don’t need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes to docstring and also removed ...
.
closes: #21597