-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Sagemaker DeleteModelOperator and Delete model hook. #21673
Conversation
Sure! Valid point @eladkal . Can see its missing for sagemaker altogether. Will do it . The failed test ' |
It could be flaky failure. Try again. |
Yep probably not related. Once you will add the docs and example I'll review |
0f04379
to
7c43d25
Compare
can you please check the code and share your feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferruzzi will you be able to also review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
1bc8949
to
5a874d6
Compare
5a874d6
to
37d1a29
Compare
f7765a4
to
d4bf264
Compare
Looks like my points have been addressed other than that new question about the indenting of the START/END flag in the sample DAG, which may or may not be a concern. Thanks for the changes. |
Thanks a lot for review :) No it does not failed for me. |
If in doubt rebase. In this case it will help as it has been fixed on main. |
Thanks @ashb ! I already did it twice before but let me do it again :) Thanks for the help!! |
d4bf264
to
161b968
Compare
161b968
to
06aac01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
This PR implements operator for Sagemaker operator and hooks to delete the Sagemaker model
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.