New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oracle test connection #21699
Merged
potiuk
merged 6 commits into
apache:main
from
hubert-pietron:fix-oracle-test-connection
Feb 26, 2022
Merged
Fix oracle test connection #21699
potiuk
merged 6 commits into
apache:main
from
hubert-pietron:fix-oracle-test-connection
Feb 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Feb 21, 2022
uranusjr
requested changes
Feb 21, 2022
uranusjr
approved these changes
Feb 21, 2022
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Feb 21, 2022
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
hubert-pietron
force-pushed
the
fix-oracle-test-connection
branch
from
February 22, 2022 10:31
a89a7be
to
65db241
Compare
potiuk
approved these changes
Feb 26, 2022
jedcunningham
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Feb 28, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
full tests needed
We need to run full set of tests for this PR to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #18967
Testing connection via "select 1" for Oracle database doesn't work. This PR replace it with checking connection using table dual which is automatically created by database. I added test to prevent future changes in method.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.