Fix stray order_by(TaskInstance.execution_date) #21705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
approved these changes
Feb 21, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Thank you for fixing this! |
uranusjr
force-pushed
the
avoid-order-by-ti-execution-date
branch
from
e96650b
to
6497ffb
Compare
|
Change looks good, but I thought this would work through theh association_proxy anyway? Obviously not by the error report |
|
|
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 20, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit bb577a9)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit bb577a9)
36 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21656.
Nobody noticed this exists because the function
BaseOperator.get_task_instances()is not used anywhere in the code base. But since this is public API, we should still fix it.A quick search for
order_by(TaskInstance.execution_date)andorder_by(TI.execution_date)yielded no other results; this is probably the only one we missed.