-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webserver PodDisruptionBudget #21735
Conversation
LGTM but some tests are faiing. Can you please rebase and see if this is not caused by it ? |
Sure, rebased. |
@potiuk tests are green now |
I think it would be needed to add helm chart tests for it. |
@jedcunningham ? Do you concur? |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. What do you think about just exposing podDisruptionBudget.maxUnavailable
, instead of having the extra config
layer?
We should also add support for minAvailable
too.
Tests are failing:
I don't understand very well the error, I've already added @jedcunningham may you help me? thanks |
I wonder if the null can't land in the actual yaml sent to k8s. That's a k8s validation error, not our schema. Try removing the default |
I just noticed that Sorry for the detour. I'm thinking we should remove the addition of |
Thanks @mirobertod 🎉 |
Add PodDisruptionBudget for the webserver component to helm chart