Configurable AWS Session Factory #21778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
alexchen8
force-pushed
the
aws-session-factory
branch
2 times, most recently
from
5755c73
to
05ea2f6
Compare
|
The change is fine but it has zero user-facing documentation. Please explain it in the amazon providers howtos and docstrings. Some examples of usage where it can be used should be added. |
alexchen8
force-pushed
the
aws-session-factory
branch
from
05ea2f6
to
7179646
Compare
alexchen8
changed the title
|
Added documentation. Not sure if it's in the right format. |
potiuk
approved these changes
Feb 28, 2022
This looks super cool! |
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
84 tasks
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable AWS SessionFactory for users to have full control of AWS boto3 session instantiation. This will also allow custom federated AWS access.
closes: #21672