-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin pandas-gbq
and remove unused code
#21915
Conversation
`BigQueryPandasConnector` was previously used by `BigqueryHook.get_pandas_df`. This was fixed in apache@ad308ea (**in 2018**). However we forgot to remove `BigQueryPandasConnector` which is age-old code (2016) and used private methods. 2016 code - https://github.com/apache/airflow/pull/1452/files
Single SQLite failure is unrelated |
Any backcompat concerns? We can bump the major for the provider easy enough, but not as straight forward with the contrib in core. |
Hardly think so, ancient code that doesn't make sense to use in isolation. So I don'g see any concerns |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Hell yeah :) |
Cherry-pick from the community: apache/airflow#21915 Change-Id: I3efc8877edb2dc667b69e5d8172c5f180b8d54d0 GitOrigin-RevId: 68199e10f232e58485f0224f00c54f06efd05343
BigQueryPandasConnector
was previously used byBigqueryHook.get_pandas_df
. This was fixed in ad308ea (in 2018). However we forgot to removeBigQueryPandasConnector
which is age-old code (2016) and used private methods.2016 code - https://github.com/apache/airflow/pull/1452/files
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.