Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pandas-gbq and remove unused code #21915

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 1, 2022

BigQueryPandasConnector was previously used by BigqueryHook.get_pandas_df. This was fixed in ad308ea (in 2018). However we forgot to remove BigQueryPandasConnector which is age-old code (2016) and used private methods.

2016 code - https://github.com/apache/airflow/pull/1452/files


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from potiuk March 1, 2022 21:33
@kaxil kaxil requested a review from turbaszek as a code owner March 1, 2022 21:33
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 1, 2022
`BigQueryPandasConnector` was previously used by `BigqueryHook.get_pandas_df`. This was fixed in apache@ad308ea (**in 2018**). However we forgot to remove `BigQueryPandasConnector` which is age-old code (2016) and used private methods.

2016 code - https://github.com/apache/airflow/pull/1452/files
@kaxil
Copy link
Member Author

kaxil commented Mar 1, 2022

Single SQLite failure is unrelated

@kaxil kaxil requested a review from jedcunningham March 1, 2022 22:51
@jedcunningham
Copy link
Member

Any backcompat concerns? We can bump the major for the provider easy enough, but not as straight forward with the contrib in core.

@kaxil
Copy link
Member Author

kaxil commented Mar 2, 2022

Any backcompat concerns? We can bump the major for the provider easy enough, but not as straight forward with the contrib in core.

Hardly think so, ancient code that doesn't make sense to use in isolation. BigQueryPandasConnector was previously used by BigqueryHook.get_pandas_df. This was fixed in ad308ea (in 2018). However we forgot to remove BigQueryPandasConnector which is age-old code (2016) and used private methods.

So I don'g see any concerns

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 2, 2022
@potiuk potiuk merged commit 84ed747 into apache:main Mar 2, 2022
@potiuk
Copy link
Member

potiuk commented Mar 2, 2022

Hell yeah :)

@jedcunningham jedcunningham deleted the unpin-pandas-gbq branch March 2, 2022 16:10
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 2, 2022
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 30, 2022
Cherry-pick from the community:
apache/airflow#21915

Change-Id: I3efc8877edb2dc667b69e5d8172c5f180b8d54d0
GitOrigin-RevId: 68199e10f232e58485f0224f00c54f06efd05343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants