Add map_index label to mapped KubernetesPodOperator #21916
Conversation
boring-cyborg
bot
added
provider:cncf-kubernetes
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
| } | ||
| ti = context['ti'] | ||
|
|
||
| labels = {'dag_id': ti.dag_id, 'task_id': ti.task_id, 'execution_date': context['ts']} |
There was a problem hiding this comment.
probably we should replace execution_date with run_id here, since that is now the "real" PK component right?. the signifigance of these labels, AFAIK, is just for "reattaching" to a pod after interruption, so it's just meant to be attrs that uniquely identify the TI. though it needn't necessarily be done in this PR of course.
There was a problem hiding this comment.
I had that at first here but it makes the change about task mapping hard to see, so I've got it in a separate commit/pr
(If you haven't noticed I'm a big fan of Pr=one thing, especially as changelog comes from commit messages.)
ephraimbuddy
added
the
changelog:skip
This seems remarkable simple. Have I missed something?