added docker network_mode options in documentation #21986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowrna
commented
Mar 4, 2022
| bridge - Create new network stack for the container with default docker bridge network | ||
| None - No networking for this container | ||
| container:<name|id> - Use the network stack of another container specified via <name|id> | ||
| host - Use the host network stack. Incompatible with `port_bindings` |
There was a problem hiding this comment.
In host network stack, port_binding option is incompatible as container and it's host shares same networking namespace and the container has the same IP address as that of the host. However in create_host_config function in DockerOperator we don't support port_binding as param. So I am not sure if we have to add this detail Incompatible with port_bindings in the documentation.
Bowrna
force-pushed
the
docker-network-docs
branch
3 times, most recently
from
bd775b0
to
dc08e17
Compare
Bowrna
force-pushed
the
docker-network-docs
branch
from
dc08e17
to
11022cc
Compare
potiuk
approved these changes
Mar 6, 2022
84 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8418
related: #8418
Added documentation for Docker operator network_mode option.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.