Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow migration jobs and init containers to be optional #22195

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

ajbosco
Copy link
Contributor

@ajbosco ajbosco commented Mar 11, 2022

Currently, the Helm Chart forces using the migration job to run db migrations, but this has a few issues (not supporting --wait and --atomic helm installs being the biggest. This PR makes that job (and the accompanying init containers on deployments) optional. All defaults match the existing behavior so nothing should change for current Chart users.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 11, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 11, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should add some tests.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wonder if we should have a single waitForMigrations flag instead of individual ones? Haven't really thought it through though.

@jedcunningham jedcunningham added the type:new-feature Changelog: New Features label Mar 11, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 11, 2022
@ajbosco
Copy link
Contributor Author

ajbosco commented Mar 14, 2022

Looks good.

I wonder if we should have a single waitForMigrations flag instead of individual ones? Haven't really thought it through though.

@jedcunningham yeah I wasn't sure if a single flag would be better and went with more flexibility.

@jedcunningham jedcunningham merged commit d78e086 into apache:main Mar 22, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 22, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @ajbosco! Congrats on your first commit, at least in the last few years (bot got confused 🤷‍♂️) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart full tests needed We need to run full set of tests for this PR to merge okay to merge It's ok to merge this PR as it does not require more tests type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants