Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Classifier release for March 2022 #22226

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 13, 2022

This is a bulk-release of all providers - it includes
some providers that actually changed, but most of
the providers are just adding the two classifiers:

  • Framework :: Apache Airflow
  • Framework :: Apache Airflow :: Provider

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:amazon-aws AWS/Amazon - related issues provider:snowflake Issues related to Snowflake provider labels Mar 13, 2022
@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2022

Docs for RC2 of Feb providers:

  • amazon and dbt.cloud - bug fixes
  • snowflake and databricks- Upcoming Python 3.10-related changes

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 13, 2022
@potiuk potiuk force-pushed the add-rc2-feb-2022-packages branch 2 times, most recently from fc31395 to 6398c1e Compare March 14, 2022 11:52
@potiuk potiuk changed the title Add documentation for RC2 package release for Feb 2022 Add documentation for Classifier release for March 2022 Mar 14, 2022
@potiuk potiuk requested a review from uranusjr March 14, 2022 11:53
@potiuk potiuk marked this pull request as draft March 14, 2022 11:53
@potiuk
Copy link
Member Author

potiuk commented Mar 14, 2022

Hey @eladkal - I think re-review will be needed :) as after the Trove Classifiers became available I decided to release all packages again - with the Trove classifier included.

I also converted it to draft as I found out during preparation that there was a backwards incompatible change implemented in #22112 in a number of providers that makes them only compatible with the upcoming 2.3.0+, this needs to be fixed before we release the providers. See #22112 (comment)

@potiuk
Copy link
Member Author

potiuk commented Mar 14, 2022

I also used the opportunity to move all the static data from setup.py to setup.cfg generated for providers.

@potiuk
Copy link
Member Author

potiuk commented Mar 14, 2022

(BTW: pressing the "." in the UI and opening web-browser-vscode makes it much easier to review such big PR. It takes quite a bit time to load but once it does, it's much more usable).

Environment :: Web Environment
Intended Audience :: Developers
Intended Audience :: System Administrators
Framework :: Apache Airflow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure if we want to add also "Framework :: Apache Airflow" as classifier here. I guess we do (otherwise only "apache-airlfow" package would be applicable to have it) @ashb @kaxil WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agreed, we should add it.

I consider it as "Projects using Apache Airflow"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@potiuk potiuk force-pushed the add-rc2-feb-2022-packages branch 4 times, most recently from c40d870 to b3ec153 Compare March 14, 2022 19:37
This is a bulk-release of all providers - it includes
some providers that actually changed, but most of
the providers are just adding the two classifiers:

* Framework :: Apache Airflow
* Framework :: Apache Airflow :: Provider
@potiuk potiuk marked this pull request as ready for review March 14, 2022 20:54
@potiuk
Copy link
Member Author

potiuk commented Mar 14, 2022

Should be ready for re-review @eladkal :)

@potiuk potiuk merged commit 16adc03 into apache:main Mar 14, 2022
@potiuk potiuk deleted the add-rc2-feb-2022-packages branch March 14, 2022 22:17
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 20, 2022
The TroveClassifiers change apache#22226 - by mistake - added the
gitpython and wheel for all providers.

This could have been avoided (and noticed) if we split the change
from doc generation. So as a learning I separate a fix to only
fix the problem.

Fix apache#22380
potiuk added a commit that referenced this pull request Mar 20, 2022
The TroveClassifiers change #22226 - by mistake - added the
gitpython and wheel for all providers.

This could have been avoided (and noticed) if we split the change
from doc generation. So as a learning I separate a fix to only
fix the problem.

Fix #22380
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 22, 2022
This is another out-of-band release of Providers after we
found out that the apache#22226 wrongly added gitpython and wheel
as dependencies for all providers.
potiuk added a commit that referenced this pull request Mar 22, 2022
This is another out-of-band release of Providers after we
found out that the #22226 wrongly added gitpython and wheel
as dependencies for all providers.
@potiuk potiuk restored the add-rc2-feb-2022-packages branch April 26, 2022 20:53
@potiuk potiuk deleted the add-rc2-feb-2022-packages branch July 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants