Helm support local kubernetes executor #22388
Conversation
|
Hey @subkanthi, let's get this in the next release so we have day 1 support when 2.3.0 goes out. I think we have a test to fix, otherwise this is ready to go right? |
|
subkanthi
changed the title
| @@ -327,7 +327,8 @@ def test_unsupported_executor(self): | |||
| }, | |||
| ) | |||
| assert ( | |||
| 'executor must be one of the following: "LocalExecutor", "CeleryExecutor", ' | |||
| 'executor must be one of the following: "LocalExecutor", ' | |||
There was a problem hiding this comment.
Assert on the error message maybe is not a good idea
There was a problem hiding this comment.
It's a little fragile, yeah, but honestly it changes so infrequently I think it's okay.
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Helm changes to support LocalKubernetesExecutor
Airflow Docker images dont have the #19729 changes yet.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.