Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_first_depends_on_past for scheduled jobs #22491

Merged

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Mar 23, 2022

solves this issue #8989


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@pingzh pingzh force-pushed the pinzh-ignore_first_depends_on_past_by_default branch 5 times, most recently from 0679b2d to f778e69 Compare March 23, 2022 20:39
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 23, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@pingzh pingzh force-pushed the pinzh-ignore_first_depends_on_past_by_default branch from f778e69 to f8712d1 Compare March 23, 2022 22:51
@pingzh pingzh force-pushed the pinzh-ignore_first_depends_on_past_by_default branch from f8712d1 to b139211 Compare March 24, 2022 16:36
@pingzh pingzh requested a review from uranusjr March 24, 2022 16:36
@pingzh pingzh force-pushed the pinzh-ignore_first_depends_on_past_by_default branch from b139211 to 5393d4c Compare March 24, 2022 16:36
@pingzh pingzh closed this Mar 24, 2022
@pingzh pingzh reopened this Mar 24, 2022
@pingzh
Copy link
Contributor Author

pingzh commented Mar 24, 2022

@uranusjr addressed your feedback.

@pingzh pingzh force-pushed the pinzh-ignore_first_depends_on_past_by_default branch from 5393d4c to 8df129c Compare March 24, 2022 19:19
@uranusjr uranusjr merged commit 8e7cb1f into apache:main Mar 25, 2022
@pingzh pingzh deleted the pinzh-ignore_first_depends_on_past_by_default branch March 25, 2022 01:38
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Apr 8, 2022
@adm-huboo
Copy link

@pingzh this is great stuff, exactly what I need! But we are using managed version of Airflow on AWS which is 2.2.2. Is there any way to apply this functionality without updating airflow to 2.3?

@potiuk
Copy link
Member

potiuk commented Nov 14, 2022

@pingzh this is great stuff, exactly what I need! But we are using managed version of Airflow on AWS which is 2.2.2. Is there any way to apply this functionality without updating airflow to 2.3?

Nope. You need to insit on them to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants