Add more fields to REST API get DAG(dags/dag_id) endpoint #22637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
mik-laj,
kaxil,
XD-DENG and
ashb
as code owners
uranusjr
approved these changes
Mar 31, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Mar 31, 2022
The DagModel columns have increased since this endpoint was created. This PR improves the endpoint by including all the missing fields of the DagModel on the endpoint. This update also touched on DAGDetails schema because it inherits from DAGSchema. In a future PR, when more details would be added to the DAGDetails endpoint, we could separate it from the DAGSchema. They are related but not really the same. One is a database object while the other is not
ephraimbuddy
force-pushed
the
add-more-fields-to-dag
branch
from
c7c37d3
to
1bfabbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DagModel columns have increased since this endpoint was created. This PR improves the endpoint by including all the missing fields of the DagModel on the endpoint.
This update also touched on DAGDetails schema because it inherits from DAGSchema. In a future PR, when more details would be added to the DAGDetails endpoint, we could separate it from the DAGSchema. They are related but not really the same. One is a database object while the other is not
closes: #22325