Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent meta name clash for task instances #22783

Merged
merged 1 commit into from Apr 6, 2022
Merged

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 6, 2022

We had two <meta> variables with the name of task_instances_url. This was causing refresh in graph view to call the wrong endpoint. Now, we specify with task_instances_list_url.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 6, 2022
@bbovenzi bbovenzi merged commit 7361c6d into main Apr 6, 2022
@bbovenzi bbovenzi deleted the fix-graph-refresh branch April 6, 2022 15:21
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
@bbovenzi bbovenzi added this to the Airflow 2.3.0 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants