Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection test button #23345

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

jedcunningham
Copy link
Member

The connection test button was always disabled if any of your hooks had
import errors, for example because of a missing module. This handles
that scenario.

The connection test button was always disabled if any of your hooks had
import errors, for example because of a missing module. This handles
that scenario.
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 28, 2022
@jedcunningham jedcunningham added this to the Airflow 2.3.1 milestone Apr 28, 2022
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 28, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 28, 2022
@ashb ashb merged commit f197030 into apache:main Apr 29, 2022
@ashb ashb deleted the fix_connection_test_button branch April 29, 2022 10:29
ephraimbuddy pushed a commit that referenced this pull request May 8, 2022
The connection test button was always disabled if any of your hooks had
import errors, for example because of a missing module. This handles
that scenario.

(cherry picked from commit f197030)
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
The connection test button was always disabled if any of your hooks had
import errors, for example because of a missing module. This handles
that scenario.

(cherry picked from commit f197030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants