Introduce sla_miss metric #23402
Introduce sla_miss metric #23402
Conversation
Jorricks
requested review from
kaxil,
potiuk,
jedcunningham and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:Scheduler
| @@ -231,6 +233,7 @@ def test_dag_file_processor_sla_miss_doesnot_raise_integrity_error(self, dag_mak | |||
| .count() | |||
| ) | |||
| assert sla_miss_count == 1 | |||
| mock_stats_incr.assert_called_with('sla_missed') | |||
There was a problem hiding this comment.
Super small nit: There are other tests that already mock the stats object (for testing other SLA related metrics) that you could add this line to, instead of adding a net-new mock object to this test. But it's not a big deal, still approving. Thanks for the commit :)
There was a problem hiding this comment.
Yes I thought about this but I choose this test on purpose as this is one of the only ones(if not the only one) that creates the SLA by the scheduler code (instead of creating it inside the testing code).
Therefore I feel like this was the best way to do it.
|
Just looking through open PRs I've reviewed. Is there any development waiting for this one @Jorricks? Or is it just awaiting a review from a committer? |
|
needs at least rebase to fix conflict |
|
@Jorricks can you rebase and resolve conflicts? |
|
Hey, |
|
Rebased again @Jorricks - we had some "Werkzeug" drama this morning. But I am afraid some tests that failed will fail again and will need to be fixed :( |
|
@potiuk could you please help me out here? |
|
Likely it was intermittent failure |
|
MsSQL is not the most "stable" part of our CI. |
So should we merge this then? |
|
Why not :) |
We have a metric for both sla callback failures and sla email failures.
However, we are not tracking when an SLA is not met.
This is crucial to know how many SLAs we had in total in statsd/prometheus.
Update: Forgot to install pre-commit :) Will fix it in a bit.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.