Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCSDeleteObjectsOperator empty prefix bug fix #24353

Merged
merged 4 commits into from
Jun 19, 2022
Merged

GCSDeleteObjectsOperator empty prefix bug fix #24353

merged 4 commits into from
Jun 19, 2022

Conversation

Lavedonio
Copy link
Contributor

@Lavedonio Lavedonio commented Jun 9, 2022

closes: #24352
This PR solves the Issue #24352 for a bug found in GCSDeleteObjectsOperator, where an error was thrown if the parameter prefix was set to an empty string, which should be a valid input.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@Lavedonio Lavedonio requested a review from turbaszek as a code owner June 9, 2022 17:39
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 9, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 11, 2022
@potiuk
Copy link
Member

potiuk commented Jun 14, 2022

Static checkes are failing

@Lavedonio
Copy link
Contributor Author

Static checkes are failing

Just saw it right now. I can check that later today.

@Lavedonio
Copy link
Contributor Author

All checks passed.

@turbaszek I think your review might also be needed in order to merge.

@eladkal
Copy link
Contributor

eladkal commented Jun 15, 2022

@Lavedonio can you add test case with empty string to verify it works as expected and to avoid regression?

@Lavedonio
Copy link
Contributor Author

Is anything else needed on my side?

@potiuk potiuk merged commit e7a1c50 into apache:main Jun 19, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 19, 2022

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Jun 19, 2022

@Lavedonio - just pinging when you'v done what you are asked for. Pushing an updated commit does not automatically mean information "I applied the fixes" - the best way to inform the maintainers is to ping them and mention it specifically that "you fixed it". You should be aware we have sometimes 30-50 conversation to look at a day - where you have just one PR. Watch my presentation here to understand more https://www.youtube.com/watch?v=G6VjYvKr2wQ

@Lavedonio
Copy link
Contributor Author

@potiuk thanks for pointing that out. This is the first contribution that I've made to an open-source project, so I wasn't quite aware of how this final interaction worked. I'll make sure to watch your presentation later, thanks for the resource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCSDeleteObjectsOperator raises unexpected ValueError for prefix set as empty string
4 participants