Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix await_container_completion condition (#23883)" #24474

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jedcunningham
Copy link
Member

This reverts commit 42abbf0.

Trying to determine if this is the source of the failing k8s tests.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers labels Jun 15, 2022
@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Jun 15, 2022
@potiuk potiuk closed this Jun 15, 2022
@potiuk potiuk reopened this Jun 15, 2022
@potiuk
Copy link
Member

potiuk commented Jun 15, 2022

Reopened with "full-tests-needed" to check if it it really fixes the problem

@jedcunningham jedcunningham changed the title DONT MERGE: Revert "Fix await_container_completion condition (#23883)" Revert "Fix await_container_completion condition (#23883)" Jun 15, 2022
@potiuk potiuk marked this pull request as ready for review June 15, 2022 16:22
@potiuk potiuk merged commit dba3e4e into apache:main Jun 15, 2022
@jedcunningham jedcunningham deleted the pinpoint_failing_test_change branch June 15, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants