Fix deprecated log_id_template value #24506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
We had the wrong old default in our deprecated value upgrading logic, so 2.2.5 default wasn't actually being upgraded.
jedcunningham
force-pushed
the
fix_deprecated_log_id_template
branch
from
b04282c
to
20146c4
Compare
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 29, 2022
We had the wrong old default in our deprecated value upgrading logic, so the 2.2.5 default wasn't actually being upgraded. (cherry picked from commit a955ae4)
This was referenced Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the wrong old default in our deprecated value upgrading logic, so
2.2.5 default wasn't actually being upgraded.