Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use older version of node for pre-commit checks #24688

Merged
merged 2 commits into from Jun 29, 2022

Conversation

kevgeo
Copy link
Contributor

@kevgeo kevgeo commented Jun 27, 2022

This PR is for airflow to use an older version of node.js when running the pre-commit checks as newer version of node may cause glibc issues on older systems such as ubuntu 16.04lts.

I have discussed this with @potiuk on slack.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 27, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@kevgeo kevgeo force-pushed the older_node_version-pre-commit branch from 43728b6 to bac490c Compare June 28, 2022 18:33
@potiuk potiuk force-pushed the older_node_version-pre-commit branch from bac490c to 058f0b7 Compare June 28, 2022 21:29
@jedcunningham jedcunningham merged commit 7e6c938 into apache:main Jun 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 29, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @kevgeo! Congrats on your first commit 🎉

@kevgeo
Copy link
Contributor Author

kevgeo commented Jun 30, 2022

Thank you @jedcunningham 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants