-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DockerOperator
fix cli.logs giving character array instead of string
#24726
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks okay.
I do wonder if there was some reason that we called got the logs again instead of using tht lines we already had. I expect not, but I wonder who might know.
DockerOperator
fixed issue where cli.logs was giving character array instead of string
DockerOperator
fixed issue where cli.logs was giving character array instead of stringDockerOperator
fix cli.logs giving character array instead of string
@ferruzzi - any comments ? |
uranusjr wanted it that way, see discussion here: #21175 (comment) |
I believe the issue solved with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ashb any doubts ? |
Nope. |
Awesome work, congrats on your first merged pull request! |
Cool. Sorry, I should have phrased it as "at the time..." but you got the point. Nice fix. 👍 |
closes: #24681
Based on ticket 24681.
cli.logs
behaviour is not fixed sometimes it returns the array of character rather than one single string.This changes was brought as part of change Before that it was returning the data from log_lines. Reverting to some part of it to get correct line