Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all NBSP characters by whitespaces #24797

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

BasPH
Copy link
Contributor

@BasPH BasPH commented Jul 2, 2022

This PR replaces all NBSP characters by whitespaces. Not visible in GitHub, but e.g. PyCharm displays them:

Greenshot 2022-07-02 08 32 20

NBSP characters can lead to hard to discover issues when copy-pasting.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting they creped into there in the first place. nice catch.

@potiuk
Copy link
Member

potiuk commented Jul 4, 2022

Some copy&paste from word :) likely

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add pre commit to avoid future cases?

@potiuk
Copy link
Member

potiuk commented Jul 5, 2022

Can we add pre commit to avoid future cases?

Good point

@potiuk potiuk merged commit 1abdf3f into apache:main Jul 5, 2022
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants