Move javascript compilation to host

[potiuk]

Previously, in order to keep consistent development environment
we've compiled javascript in the CI image. However we can utilise
power of pre-commmit for setting the node environment for all
contributors automatically. Instead of compiling the javascript
in the image, we can compile it via pre-commit in the host.

This can be done thanks to the new python breeze which is far more
flexible and can now add execution of compilation of the javascript when
needed and using pre-commit environments.

Thanks to that, we can vastly simplify the Dockerfiles and scripts that
are used to automatically build or signal that the assets need
recompilation. We can basically assume that the assets were prepared
outside of the image building (and breeze makes sure it happens)

The changes:

• node.js is not needed in images (neither PROD build nor CI)
• no need for multiple asset compilation scripts. All is done
  via pre-commit environment with `breeze compile-www-assets``
  command
• lint checks for UI do not need the docker image any more
  (they are also based on pre-commit environment)
• no more checks/warnings when you enter the image
• start-airflow command builds the compilation before entering
• prepare-airflow-package runs asset compilation before entering
  docker airflow building.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[potiuk]

cc: @pierrejeambrun @bbovenzi - please take a look, I think you will find this change really cool.

[bbovenzi]

Tested this out locally. Everything seems to be working. But does look like we need a quick rebase.

[potiuk]

Cool. Yeah. I will . :)

[potiuk]

Thanks for testing @bbovenzi - > I think this will help a bit with faster iterations and maybe we could also add some more dev-friendly javascript tooling around to attract more contributors and make it easier to start/test/debug Javascript code. Especially with the typescript and React, I have a feeling we could add some tooling to breeze to improve "first-time-experience" for new users. Happy to brainstorm on it and implement any improvements there :)

[potiuk]

Hm. Interestingly enough - we seem to have not enough space on our machines to get THREE yarn installs :)

[bbovenzi]

Hm. Interestingly enough - we seem to have not enough space on our machines to get THREE yarn installs :)

Are we not clearing the cache each time?

[potiuk]

Not when we have three independent yarn builds run in pre-commits - the envs are created in ~/.cache which is rather small it seems, But I am looking into it.

[potiuk]

Let's see now :)

[potiuk]

Added more disk space for the instance (later I can optimize it even more).

[potiuk]

Now we are cooking with gas. I will just re-run it with public runners to be absolutely sure the yarn modules will not make it run out of the capacity either.

[MatrixManAtYrService]

I have some automation which runs python setup.py compile_assets bdist_wheel in service of creating an airflow image for test. Following this commit, it fails with:

[Errno 2] No such file or directory: './airflow/www/compile_assets.sh': './airflow/www/compile_assets.sh'

Is that a bug, or is there a better way for me to be building this?

[potiuk]

A bug. fix is coming

[potiuk]

PR here: #25201

[potiuk]

Merged. Should be fixed now @MatrixManAtYrService