Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve taskflow type hints with ParamSpec #25173

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Improve taskflow type hints with ParamSpec #25173

merged 2 commits into from
Jul 26, 2022

Commits on Jul 26, 2022

  1. Improve taskflow annotation with ParamSpec 

    This is made available with our latest Mypy update. ParamSpec allows us
to more accurately type a decorated task to return an XComArg (while
still being correctly typed to accept the same arguments as the
decorated function). This allows us to provide autocompletion for
XComArg operations, such as map() and zip() introduced in AIP-42.
    @uranusjr
    uranusjr committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    2b24dda View commit details
    Browse the repository at this point in the history

  2. More type fixes

    @uranusjr
    uranusjr committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    dcfa461 View commit details
    Browse the repository at this point in the history