Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1541] Add channel to template fields of slack_operator #2549

Closed
wants to merge 1 commit into from

Conversation

Acehaidrey
Copy link
Contributor

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Our company (unfortunately) doesn't stay consistent between ldap users and slack user id's, so we have to use a PythonOperator to get the slack user name and pass that via xcom. We want to DM the person on slack, and the channel field needs to be templated to run something like "{{ task_instance.xcom_pull(task_ids='get_slack_userid') }}"
    This PR is to allow for that.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    We're simply adding a template field, so testing isn't necessary though could be done.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

Codecov Report

Merging #2549 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   70.88%   70.85%   -0.04%     
==========================================
  Files         150      150              
  Lines       11585    11585              
==========================================
- Hits         8212     8208       -4     
- Misses       3373     3377       +4
Impacted Files Coverage Δ
airflow/operators/slack_operator.py 0% <0%> (ø) ⬆️
airflow/jobs.py 77.67% <0%> (-0.28%) ⬇️
airflow/models.py 87.12% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4b024...9c974c6. Read the comment docs.

@Acehaidrey
Copy link
Contributor Author

@aoen or @criccomini any way to get a quick look at this since it's super simple?

@aoen
Copy link
Contributor

aoen commented Aug 30, 2017

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants